lsm / neokai / 24949605770

82%

push

github

feat(web): unify session Tools modal — session-scoped, deferred toggles (#1637)

* feat(web): unify session Tools modal with session-scoped, deferred toggles

Reshapes the per-session Tools modal so it never mutates global registry
state and instead presents a single Skills list + single MCP Servers list,
with all toggles deferred until the user clicks Save.

- shared: add ToolsConfig.disabledSkills (session-scope skill disable list)
- daemon: QueryOptionsBuilder filters builtin/plugin/mcp_server skills by
  session disabledSkills, additive on top of room overrides
- web: merge "App Skills & MCP" + "Project MCP Servers" into unified
  "Skills" and "MCP Servers" sections with source badges per row; toggles
  stage local pending state and apply atomically on Save via tools.save +
  mcp.enablement.setOverride/clearOverride
- web: drop direct skill.setEnabled calls from the session modal — global
  registry is untouched by per-session changes

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* test(daemon)+chore(web): address review feedback for unified Tools modal

- Add builtin-skill regression test for `disabledSkills` filter — covers
  the third path (`buildPluginsFromBuiltinSkills`) alongside the existing
  plugin and mcp_server cases.
- Correct misleading comment in `handleSave`: `tools.save` updates
  `session.config` and emits `session.updated`; the SDK query is rebuilt
  per-message via `QueryOptionsBuilder.build()` rather than via an
  explicit restart.
- Make `void` prefix consistent across async fire-and-forget loaders in
  the modal mount effect.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

9231 of 12389 branches covered (74.51%)

Branch coverage included in aggregate %.

36 of 37 new or added lines in 2 files covered. (97.3%)

66341 of 78707 relevant lines covered (84.29%)

299.16 hits per line