lsm / neokai / 24934805579

82%

push

github

fix(web): align Tasks nav badge with Action tab (#1635)

* fix(web): align Tasks nav badge with Action tab via shared predicate

The per-space Tasks badge previously read `spaceStore.attentionCount`
(server-side `spaceTasks.needingAttention` LiveQuery — review +
blocked-with-`human_input_requested`/`gate_rejected`), while the Action
tab listed every blocked or review task. With 2 plain-blocked tasks and
0 review tasks, the badge rendered nothing while the Action tab showed
2 — a confusing drift.

Extract `isActionRequired(task)` / `isActiveTask(task)` into
`lib/task-filters.ts` and use them for both the Action tab filter, the
tab counts, and the Tasks-nav badge in `SpaceDetailPanel`. The badge
now reflects exactly what's listed under the Action tab and the two
can no longer disagree.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(web): route SpaceTasks Action tab through isActionRequired and drop dead spaceTasks.needingAttention plumbing

- SpaceTasks.tsx: replace inline TAB_GROUPS status arrays with TAB_PREDICATES
  whose `action` slot reuses the shared `isActionRequired` predicate, so the
  Action tab and the SpaceDetailPanel Tasks-nav badge share one source of
  truth and cannot drift again.
- space-store.ts: remove the now-unused `attentionTasks` / `attentionCount`
  signals and `subscribeAttentionTasks` / `disposeAttentionTasksSubscription`
  plumbing (badge + tab now derive from the existing tasks LiveQuery via the
  predicate).
- daemon: drop the `spaceTasks.needingAttention` named LiveQuery (SQL
  constant + registry entry) and its dedicated test block — no client
  subscribes to it any more.
- tests: clean up the test mocks (`mockAttentionCountSignal`,
  `mockAttentionCount`) that referenced the removed store fields.
- docs: refresh the space-autonomy gap entry to describe the new
  client-side predicate approach instead of the removed server query.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

---------

Co-... (continued)

9082 of 12161 branches covered (74.68%)

Branch coverage included in aggregate %.

16 of 16 new or added lines in 3 files covered. (100.0%)

65975 of 78310 relevant lines covered (84.25%)

299.13 hits per line