lsm / neokai / 24934595219

82%

push

github

fix(daemon): recover stalled workflow runs on daemon restart (#120) (#1636)

* fix(daemon): recover stalled workflow runs on daemon restart

Adds `SpaceRuntime.recoverStalledRuns()` — a daemon-restart safety net
that scans `status='in_progress'` workflow runs and forces a sane
terminal state for runs that no agent will drive forward. Without this,
a crash that leaves every node execution `idle`/`cancelled` with no
completion signal would leave the parent task `in_progress` forever.

Recovery is invoked from `SpaceRuntimeService.start()` after
`provisionExistingSpaces()` (so member sessions have MCP tools attached
before any restart-driven `task_blocked` notifications fire) and is
double-gated by a `recoveryDone` flag with a backstop call from the
first `executeTick()`. Idempotent — whichever fires first wins.

Orphan in_progress executions whose sessions died across the restart
are intentionally left for `processRunTick`'s existing crash-retry
path, which already handles the case correctly with crash counting.
Duplicating that logic here would silently consume retries.

Closes #120

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* test(daemon): cover recoverStalledRuns() and start() ordering

Adds 12 unit tests for `SpaceRuntime.recoverStalledRuns()` covering
the blocked-on-no-signal path, completion-pending skip, driveable-
execution skip, orphan-in-progress passthrough (recovery does not
touch dead-session executions — tick path handles them), idempotency,
first-tick auto-trigger, and multi-run scans. Adds 2 service-level
tests asserting recovery runs after provisioning in start() and that
a thrown recovery does not block ready().

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* docs(daemon): clarify recoverStalledRuns next-step + start() ordering

Two doc-comment accuracy fixes flagged by review on PR #1636:

1. `SpaceRuntime.recoverStalledRuns` jsdoc previously claimed
   `attemptBlockedRunRecovery` would retry-or-escalate a r... (continued)

9090 of 12190 branches covered (74.57%)

Branch coverage included in aggregate %.

84 of 85 new or added lines in 2 files covered. (98.82%)

66016 of 78365 relevant lines covered (84.24%)

299.38 hits per line