lsm / neokai / 24919162887

82%

push

github

refactor(web): float SpaceTaskPane tab pill inside content area (#1629)

* refactor(web): float SpaceTaskPane tab pill inside content area

Move the Thread / Canvas / Artifacts tab pill out of its own row above
the content and reposition it as an absolute-positioned, frosted-glass
overlay inside the content area. Reclaims a row of vertical space and
gives the content a single continuous viewport while the pill stays
visible across all three views.

The wrapper around the pill spans the full content width so it can
center horizontally; it disables pointer-events on the wrapper and
re-enables them on the pill itself so empty space around the pill
never blocks underlying canvas / thread interactions. Tightened the
pill's background opacity (`/60` → `/80`) and added `shadow-lg` so it
reads as elevated against the content beneath it.

Adds a `task-pane-content` testid on the content wrapper plus three
new tests under "SpaceTaskPane — floating tab pill layout" covering
the overlay structure, cross-view persistence, and click-through
behaviour for the pill buttons.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(web): hoist task banners above tab content + add topInsetClass to thread

Address reviewer feedback on PR #1629:

1. Hoist `resolveActiveTaskBanner` block out of the thread else-branch
   into the SpaceTaskPane container, between the header and the
   `task-pane-content` div. Blocked / pending banners now stay visible
   when the user is on the Canvas or Artifacts tab.

2. Add `topInsetClass?: string` prop to SpaceTaskUnifiedThread and pass
   `topInsetClass="pt-12"` from SpaceTaskPane so the first message
   clears the floating tab pill at scroll-top. Older messages still
   scroll under the pill's frosted-glass background.

Also bump the pill from `top-2` → `top-3` for slightly more breathing
room above the content.

Tests:
- New: passes topInsetClass to SpaceTaskUnifiedThread
- New: renders the active banner outside task-pane-conte... (continued)

9139 of 12400 branches covered (73.7%)

Branch coverage included in aggregate %.

11 of 11 new or added lines in 1 file covered. (100.0%)

65936 of 78360 relevant lines covered (84.14%)

297.53 hits per line