lsm / neokai / 24918265212

82%

Build Type

push

github

Committed by web-flow

Commit Message

refactor(space): delete completion-action pipeline + consolidate approval banners (PR 4/5) (#1628)

* refactor(space): delete completion-action runtime pipeline (PR 4/5)

Removes the completion-action executors, pending-action pre-commit,
RPC completion-action intercept, and the `approve_completion_action`
MCP tool. After PR 2/5 every completion path runs through
`PostApprovalRouter`; completion-actions are now dead code.

Workflow-autonomy helper simplifies to a single
`isWorkflowAutoClosingAtLevel(wf, level)` check against the workflow's
`completionAutonomyLevel` — per-node `requiredLevel` on individual
completion actions no longer exists to survey.

Built-in workflows drop their `completionActions` arrays; PR merge
intent flows through the end-node → `send_message(task-agent,
data:{ pr_url, post_approval_action: 'merge_pr' })` → reviewer
post-approval session spawn → `gh pr merge` handoff (PR 3/5).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* refactor(web): consolidate task banners into single-slot renderer (PR 4/5)

Collapses the three-way conditional banner stack in `SpaceTaskPane` into
a single-slot precedence-driven renderer, and trims every banner to the
one-line-max rule.

New pieces:
  - `lib/task-banner.ts` — `resolveActiveTaskBanner(task, gates?)`
    returns a discriminated-union ActiveBanner. Precedence:
    blocked > post_approval_blocked > task_completion_pending >
    gate_pending > null.
  - `components/space/use-run-gate-summaries.ts` — shared hook so the
    banner renderer and `PendingGateBanner` reuse one gate-data
    subscription instead of each fetching independently.

`PendingCompletionActionBanner` is deleted with the runtime pipeline
(PR 4/5 §4.1). The "awaiting approval" list filter is repurposed to
match `pendingCheckpointType === 'task_completion'` so the affordance
survives the completion-action deletion.

`TaskStatusActions`'s `pendingCheckpointType` union narrows to
`'gate' | 'task_completion' | null`; ... (continued)

Coverage Stats

9138 of 12399 branches covered (73.7%)

Branch coverage included in aggregate %.

134 of 166 new or added lines in 15 files covered. (80.72%)

23 existing lines in 1 file now uncovered.

65938 of 78365 relevant lines covered (84.14%)

297.38 hits per line