Freegle / Iznik / 5789

70%

Build Type

push

circleci

Committed by web-flow

Commit Message

fix(message): soft-delete pending message on Withdrawn to prevent mod 403 (#248)

* fix(message): soft-delete pending message on Withdrawn outcome instead of hard DELETE

When a member withdraws a message still in Pending state, the Go API was
issuing DELETE FROM messages, leaving orphaned messages_groups rows.  Any
moderator who had already loaded the pending queue would then get a
misleading 403 on reject/delete because isModForMessage found the orphaned
messages_groups rows, but getMessageModContext's subsequent scan of the
now-absent messages row failed and returned nil.

V1 parity (Message::delete()): sets messages_groups.deleted=1 then
UPDATE messages SET deleted=NOW() — never a hard DELETE.  Switch to the
same soft-delete pattern so the messages row remains scannable and mods
can still act on the message after the member withdraws.

Adds TestPostMessageRejectAfterMemberWithdrawsPending to cover the 403
regression.  Updates TestPostMessageWithdrawnPending to match soft-delete.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(ci): use PORT_FREEGLE_PROD_LOCAL/PORT_MODTOOLS_PROD_LOCAL vars in health check

Hardcoded ports 3012/3013 never matched CI runner's actual ports (12012/12013),
causing the 'Wait for production containers to be healthy' step to always hang
until the 20-minute timeout on the self-hosted runner.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>

Coverage Stats

13426 of 20352 branches covered (65.97%)

Branch coverage included in aggregate %.

4 of 6 new or added lines in 1 file covered. (66.67%)

12 existing lines in 3 files now uncovered.

96345 of 132904 relevant lines covered (72.49%)

21.53 hits per line