bitcoindevkit / bdk / 24872439673

78%

push

github

Merge bitcoindevkit/bdk#2188: fix(electrum): verify txid of server-returned transactions

<a class=hub.com/bitcoindevkit/bdk/commit/d101a0973bc19ac1b64809c0d9f0cd3516e263d8">d101a0973 fix(electrum): verify txid of server-returned transactions (Elias Rohrer)

Pull request description:

  ### Description

  An Electrum server could return an arbitrary transaction when `fetch_tx()` requests a specific txid. The returned transaction was cached and used without verifying that its computed txid matches the requested one.

  Add a verification check that `tx.compute_txid() == txid` after fetching from the server, returning an error on mismatch. Include a unit test with a mock Electrum client that exercises both the mismatch rejection and the matching-txid happy path.

ACKs for top commit:
  evanlinjin:
    ACK d101a0973bc19ac1b64809c0d9f0cd3516e263d8

Tree-SHA512: aecb729fd81a5c769af84ca6c694bef6096

408 of 544 branches covered (75.0%)

Branch coverage included in aggregate %.

3 of 6 new or added lines in 1 file covered. (50.0%)

4416 of 5659 relevant lines covered (78.03%)

3199.37 hits per line