bitcoindevkit / bdk / 24875436711

78%

push

github

Merge bitcoindevkit/bdk#2182: fix: full_scan covers revealed range before applying stop_gap

<a class=hub.com/bitcoindevkit/bdk/commit/187b00747ab978a3bba21df5d14835ec31ed9fa3">187b00747<a href="https://github.com/bitcoindevkit/bdk/commit/7ea8b639339dd523af8dd9de3baca31ce38dbe6a"> test(esplora): allow(dead_code) at file level in common (Noah Joeris)
<a class="double-link" href="https://github.com/bitcoindevkit/bdk/commit/79d1f4501443559016de737fee8bdc572a99e248">79d1f4501</a> fix: full_scan covers revealed range before applying stop_gap (Noah Joeris)

Pull request description:

  Fixes #2057. `full_scan` now always covers the revealed range before applying the stop_gap

  ### Notes to the reviewers

  Replaces #2181. That PR unified full_scan and sync into one path; per @evanlinjin's feedback we're keeping them separate and doing the minimal fix here instead

  ### Changelog notice

  Fixed: full_scan now always scans the full revealed range before applying stop_gap past last_revealed.

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### New Features:

  * [x] I've added tests for the new feature
  * [x] I've added docs for the new feature

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [x] I'm linking the issue being fixed by this PR

ACKs for top commit:
  evanlinjin:
    ACK 187b00747ab978a3bba21df5d14835ec31ed9fa3

Tree-SHA512: 9899e5d85893b98fe185544286a97a1d900

414 of 550 branches covered (75.27%)

Branch coverage included in aggregate %.

31 of 36 new or added lines in 5 files covered. (86.11%)

4436 of 5682 relevant lines covered (78.07%)

3393.4 hits per line