bitcoindevkit / bdk / 24844458508

78%

push

github

Merge bitcoindevkit/bdk#2180: fix(chain): prevent integer overflow in `SpkIterator::new_with_range`

<a class=hub.com/bitcoindevkit/bdk/commit/b340e96f0221f6c3088fe5daf2b87c56b3bf4010">b340e96f0 fix(chain): prevent integer overflow in `SpkIterator::new_with_range` (Elias Rohrer)

Pull request description:

  ### Description

  The start and end bound calculations used unchecked addition which
  overflows when given `u32::MAX`, causing the iterator to silently produce
  wrong results (e.g., an empty iterator for `0..=u32::MAX` in release
  mode). Use `saturating_add` to handle the boundary correctly.

  ### Checklists

  #### All Submissions:

  * [x] I followed the [contribution guidelines](https://github.com/bitcoindevkit/bdk/blob/master/CONTRIBUTING.md)

  #### Bugfixes:

  * [ ] This pull request breaks the existing API
  * [x] I've added tests to reproduce the issue which are now passing
  * [ ] I'm linking the issue being fixed by this PR

ACKs for top commit:
  luisschwab:
    ACK b340e96f0221f6c3088fe5daf2b87c56b3bf4010

Tree-SHA512: f28ebcdb835b0c287b5cc4f1c630728d44f

407 of 542 branches covered (75.09%)

Branch coverage included in aggregate %.

2 of 2 new or added lines in 1 file covered. (100.0%)

4413 of 5653 relevant lines covered (78.06%)

3333.88 hits per line