agama-project / agama / 24845898238

64%

master: 81%

push

github

[SLE-16] Replace symlinks by file copies (bsc#1261340) (#3419)

## Problem

- Broken symlinks in generated *.gem file when creating the package in
Leap 15.6 (openSUSE Tumbleweed and Leap 16.0 are fine)
- https://bugzilla.suse.com/show_bug.cgi?id=1261340

## Solution

- Avoid using symlinks, copy the files instead

## Notes

- It turned out that the broken symlinks are generated by Ruby in Leap
15.6. But we should still remove the symlinks to avoid the same problem
accidentally in the future.
- The `gem build` command in openSUSE Tumbleweed and Leap 16.0 actually
also replaces the symlinks with file copies so the generated *.gem file
should be the same. No change from the OBS POV, it should receive the
same files.
- Added CI checks to ensure no new symlinks are introduced and to check
that all copies are the same.
- SLE 16.1 is not affected, there are no symlinks in the Ruby sources,
this is SLE 16.0 specific.

## Testing

- Tested manually
- Verified the added CI tests:
- After modifying one file the [CI
fails](https://github.com/agama-project/agama/actions/runs/24835688632/job/72695285073#step:9:9)
- After adding a new symlink the [CI
fails](https://github.com/agama-project/agama/actions/runs/24835912519/job/72696082450#step:10:12)

2228 of 4007 branches covered (55.6%)

Branch coverage included in aggregate %.

0 of 75 new or added lines in 3 files covered. (0.0%)

25577 of 39156 relevant lines covered (65.32%)

49.99 hits per line