bitcoindevkit / bdk / 24763976659

78%

Build Type

push

github

Committed by evanlinjin

Commit Message

Merge bitcoindevkit/bdk#2115: Add `prev_blockhash` validation to `CheckPoint`

c486ba758 docs: address review feedback on `prev_blockhash` validation (志宇)
031b30fb3 docs(core): address review feedback on docs and tests (志宇)
ef35b1993 fix(chain)!: make genesis immutable in `merge_chains` (志宇)
d8cb41f2c test(core): address review feedback on checkpoint tests (志宇)
9c0453c7d docs(core): Add module-level docs for `checkpoint_entry` (志宇)
3ef6ed866 feat(chain)!: Add `ApplyBlockError` for `prev_blockhash` validation (志宇)
bf6541b43 feat(chain)!: Relax the generic parameter for `LocalChain<D>` (志宇)
19b900648 test(core): add tests for CheckPoint::push and insert methods (志宇)
9971fda53 test(chain): Test `apply_update` with a single `CheckPoint<Header>` (valued mammal)
3df06096f test(chain): make `TestLocalChain` generic and add `prev_blockhash` test (志宇)
c314b2567 fix(chain): `merge_chains` now takes account of `prev_blockhash`es (志宇)
f10ba0ecb fix(core): `Checkpoint::insert` now evicts on `prev_blockhash` mismatch (志宇)
046a771b7 fix(core): `push` now errors on `prev_blockhash` mismatch (志宇)
68d1ef446 feat(core): Initial work on `CheckPointEntry` (志宇)
d4bdff08f feat(core): Add `prev_blockhash` method to `ToBlockHash` trait (志宇)

Pull request description:

  Closes #2021
  Related to #2076
  Replaces #2024
  Replaces #2091

  ### Description

  This PR adds `prev_blockhash` awareness to `CheckPoint`, enabling proper chain validation when merging checkpoint chains that store block headers or similar data with... (continued)

Coverage Stats

407 of 542 branches covered (75.09%)

Branch coverage included in aggregate %.

169 of 248 new or added lines in 3 files covered. (68.15%)

2 existing lines in 2 files now uncovered.

4412 of 5653 relevant lines covered (78.05%)

3244.83 hits per line