Freegle / Iznik / 5351

70%

master: 70%

Pull #226

circleci

fix(test): wait for navbar hydration before logout visibility check

Under parallel CI load (11 workers on self-hosted runner), the post-signup
navbar sometimes hasn't hydrated by the time `logoutIfLoggedIn` runs its
synchronous `isVisible()` checks on `#menu-option-logout` / mobile Logout
text. isVisible() returns false immediately, logging "No logout button
visible", and execution falls through to the heavyweight
`gotoAndVerify('/')` fallback. That homepage navigation under the same
load can hang the full 202.5s timeout, and the catch block repeats it,
consuming most of the 10-minute test budget and producing the
test-reply-flow-existing-user.spec.js 3.1 "20.0m" timeout seen on
CircleCI build 5322 (and intermittently on master, e.g. build 5281).

Fix: race a short `waitFor({ state: 'visible', timeout: 10000 })` on
either logout selector before the visibility checks. In the common case
hydration completes in well under 10s and the normal click path runs. If
hydration genuinely fails or the user wasn't logged in, the wait resolves
silently and the existing fall-through still works — no behaviour change
on that path.

Verified locally via the status-container Playwright API: all three
tests in test-reply-flow-existing-user.spec.js pass (3✓, 0✗).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

13286 of 20165 branches covered (65.89%)

Branch coverage included in aggregate %.

7 of 9 new or added lines in 2 files covered. (77.78%)

62058 of 87591 relevant lines covered (70.85%)

13.77 hits per line