Freegle / Iznik / 5285

70%

master: 70%

Build Type

Pull #226

circleci

Committed by edwh

Commit Message

fix(sentry): guard Leaflet Tooltip._updatePosition against null _map (NUXT3-D7B)

Sentry issue NUXT3-D7B (7387861402, 83 events / 21 users, last seen
2026-04-22) + duplicate 7375663927 (combined ~124 events): TypeError
"Cannot read properties of null (reading 'latLngToLayerPoint')" from
Leaflet's Tooltip._updatePosition in leaflet-src.esm.

Root cause: Leaflet's overlay classes (Tooltip, Popup, DivOverlay) call
`this._map.latLngToLayerPoint(...)` inside _updatePosition without
checking that _map is still bound. During Vue navigation/unmount, a
debounced/rAF-scheduled update tick can fire after map.remove() has
nulled _map, crashing with the above message.

Fix: prevent the error at source with a monkey-patch shim that null-checks
_map before delegating to the original _updatePosition.

- plugins/leafletTooltipGuard.client.js — imports leaflet-src.esm on
  client boot and wraps _updatePosition on Tooltip, Popup and DivOverlay
  prototypes. Idempotent (guarded by a marker symbol).
- tests/unit/plugins/leafletTooltipGuard.spec.js — covers: null _map,
  undefined _map, live _map path, Popup/DivOverlay, idempotency,
  missing prototypes, null `this`.

Belt-and-braces Sentry suppression so residual events from cached
bundles don't pollute Sentry:
- composables/useSuppressException.js — extended to match
  'latLngToLayerPoint' in message/stack and '_updatePosition' in stack.
  Previously only 'leaflet' was checked, which may not survive Vite
  minification in production stacks.
- plugins/sentry.client.ts — added 'latLngToLayerPoint' to ignoreErrors.
- tests/unit/composables/useSuppressException.spec.js — two new tests for
  the minified-stack Tooltip crash (Chrome and Firefox phrasings).

Same pattern as prior third-party/framework null dereferences: NUXT3-D2H
(1c7fdf614, 4d99e72d1) and NUXT3-D45 (319033dbe).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

Pull Request Pull Request #226: fix(sentry): guard Leaflet Tooltip._updatePosition against null _map (NUXT3-D7B)

Coverage Stats

13329 of 20304 branches covered (65.65%)

Branch coverage included in aggregate %.

7 of 9 new or added lines in 2 files covered. (77.78%)

19 existing lines in 6 files now uncovered.

62046 of 87256 relevant lines covered (71.11%)

14.84 hits per line