lsm / neokai / 24761020454

82%

push

github

fix(space): restore node-agent MCP tools in workflow sessions after restart (#1586)

* fix(space): restore node-agent MCP tools in workflow sessions after restart

Adds mergeRuntimeMcpServers, detachRuntimeMcpServer, and restartQuery to
AgentSession so TaskAgentManager can attach/refresh MCP tools additively
without clobbering other runtime servers (space-agent-tools, db-query, etc.).

The reinjectNodeAgentMcpServer primitive now calls mergeRuntimeMcpServers +
restartQuery so the SDK picks up the fresh node-agent tool registry when
self-healing after a daemon restart or session rehydration.

Test mocks in 5 task-agent-manager test files are updated to implement the
new interface methods; two raw SQL workflow-node seeds now include an agents
config so resolveNodeAgents does not throw on reinject.

* test(agent): add unit tests for merge/detach MCP API and updateUserMcpServers

- `detachRuntimeMcpServer`: remove, no-op when absent, no DB persistence, rotate pattern
- `updateUserMcpServers` in SessionConfigHandler: preserves SDK-type servers, replaces
  subprocess servers, prevents user-supplied servers from overwriting runtime servers,
  persists to DB, emits session.updated
- config-handlers mock: wire `updateUserMcpServers` so handler tests don't throw

* fix(space): address review feedback on MCP tool loss fixes

- Fix missing config column in the third workflow-node SQL seed
  (task-agent-manager.test.ts line ~1071) for consistency with
  the other two seeds fixed in the original commit
- config.mcp.removeServer: return an error instead of silent success
  when the caller tries to remove a runtime SDK-managed server
- Document NEOKAI_DEBUG_MCP_INVARIANTS in .env.example
- Enumerate the 6 remaining setRuntimeMcpServers call sites in the
  @deprecated JSDoc so future migrations have a clear tracking point

9069 of 12356 branches covered (73.4%)

Branch coverage included in aggregate %.

182 of 229 new or added lines in 6 files covered. (79.48%)

67059 of 75949 relevant lines covered (88.29%)

301.87 hits per line