KarpelesLab / goro / 24646820827

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

compile-clone: accept single-alias refs in clone-with property array

clone_with_013.phpt builds the with-array as

    \$with = ['x' => &\$ref];

clones once (which legitimately fails with "Cannot assign by reference
when cloning with updated properties"), then unsets \$ref and clones
again. The second clone is expected to succeed — PHP treats a
reference-typed array entry whose inner has dropped back to a single
alias as an ordinary value.

goro kept rejecting the second clone because IsRef() still returned
true after the unset (we don't auto-unref a surviving alias). Add
ZVal.AliasCount() so the clone-with guard can distinguish a truly
multi-aliased reference from the phantom-ref-of-one state, and only
throw for the multi-alias case.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 18 new or added lines in 2 files covered. (0.0%)

107 existing lines in 2 files now uncovered.

2188 of 111973 relevant lines covered (1.95%)

70.35 hits per line