KarpelesLab / goro / 24646869765

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

hashtable: deep-copy auto-unrefs phantom single-alias references

clone/bug68262.phpt:

    \$first->p = 'init';
    \$ref =& \$first->p;         // p is now a 2-alias reference
    unset(\$ref);                // alias count drops to 1
    \$clone = clone \$first;     // \$clone->p should be independent
    \$clone->p = 'foo';          // must not leak back into \$first->p
    var_dump(\$first->p);        // expected "init"

PHP treats a reference-typed hash entry whose inner has only one
observable alias left as an ordinary value at copy time — the
deep-copy unwraps it. goro was keeping the reference in place, so the
cloned object ended up sharing \$first->p's storage and the
post-clone write propagated back.

Fix: in ZHashTable.DeepCopy, when a reference entry's inner ZVal has
AliasCount() <= 1, deep-copy the value rather than the reference cell.
Uses the AliasCount helper introduced in 51cd7c17.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 10 new or added lines in 1 file covered. (0.0%)

136 existing lines in 1 file now uncovered.

2188 of 111982 relevant lines covered (1.95%)

70.34 hits per line