KarpelesLab / goro / 24646761379

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

run-operator: propagate real runtime errors from ??= LHS evaluation

coalesce/assign_coalesce_002.phpt exercises

    \$ary[new Dtor][id(\$foo)] ??= \$bar

where the Dtor temporary's __destruct() fires during key cleanup and is
supposed to be caught by the surrounding try/catch. Instead, goro was
reporting

    Fatal error: Can't use expression in write context in ... line 45

because checkExistenceAndGet propagated the throw as a generic error
and the ??= fallback path lumped all errors together as "unsupported
LHS" and rewrote the message.

Fix: when the LHS implements phpv.Writable (variable, array access,
object property, …) a non-nil checkErr is necessarily a real runtime
exception — propagate it unchanged. The "Can't use expression in
write context" rewrite stays in place for LHS kinds that are not
Writable (function calls, literals, etc.).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 8 new or added lines in 1 file covered. (0.0%)

318 existing lines in 1 file now uncovered.

2188 of 111957 relevant lines covered (1.95%)

70.36 hits per line