KarpelesLab / goro / 24646714602

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

compile-static: skip MakeRef for object-type static initializers

Wrapping static objects as references (a7be2eba) fixed
closures/closure_009.phpt but regressed constexpr/new_named_params.phpt
and closures/bug79778.phpt by changing how var_dump surfaces them (and
apparently disturbing object-id assignment for successive Vec
constructions).

Objects in PHP are always shared by handle — static $o = new Foo()
works correctly without a reference wrapper because the variable slot
holds the object handle, not the value being mutated. Refs are only
needed for scalar static vars whose value could be replaced via the
hash table's OffsetSet path (e.g. $n++).

Skip the MakeRef when the initializer evaluates to a ZObject. Also
Nude() the stored ZVal in Closure::__debugInfo's static-var section so
the reference wrapping used for scalars doesn't leak into the
displayed "static" key.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 13 new or added lines in 2 files covered. (0.0%)

1 existing line in 1 file now uncovered.

2188 of 111950 relevant lines covered (1.95%)

70.36 hits per line