KarpelesLab / goro / 24646567792

13%

push

github

compile-static: wrap initial static-var value as a reference

The earlier Dup() fix (c9ee2def) detached the cached small-int wrapper
but didn't go far enough: closure_009 was still failing because the
post-increment path snapshots the LHS value into a pooled temp ZVal,
mutates the temp, then writes back via WriteValue → OffsetSet. The
hash-table SetString path only mutates the existing entry in place
when the entry is a reference; for a plain ZVal it replaces the
pointer, so the original ZVal stored in perClosure / perClass / v.z
stays at its initializer value and the static var resets every call.

Fix: wrap the initial ZVal with MakeRef() so the hash entry is a
reference to the inner ZVal we keep. OffsetSet now propagates
writes through the reference into the inner ZVal, so subsequent
invocations see the mutated value.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

0 of 15 new or added lines in 1 file covered. (0.0%)

2188 of 111939 relevant lines covered (1.95%)

70.37 hits per line