KarpelesLab / goro / 24646382524

13%

push

github

compile-clone: keep readonly enforcement for props initialized mid-clone-with

clone_with_012 expects the second clone-with in

  clone($f, ['foo' => ..., 'bar' => ...])

to throw "Cannot modify readonly property Clazz::\$bar" because \$foo's
set hook also initializes \$bar during the clone-with pass, making \$bar
readonly by the time the explicit 'bar' => ... update fires.

Previous code unconditionally called UnmarkReadonlyInit before each
ObjectSet, which erased the flag set by the hook and let the second
write through. PHP only allows clone-with to override readonly props
that were already initialized BEFORE clone-with started (by __clone()
or the original object).

Fix: snapshot the set of readonly properties that are already initialized
when we enter the apply loop, and only unmark those. Anything that
becomes initialized during the same pass stays protected.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

0 of 15 new or added lines in 1 file covered. (0.0%)

2188 of 111934 relevant lines covered (1.95%)

70.37 hits per line