KarpelesLab / goro / 24646340404

13%

Build Type

push

github

Committed by MagicalTux

Commit Message

compile-static: ensure static var storage is a mutable (non-cached) ZVal

closure_009.phpt shows our static-var handling losing increments: the
expected sequence 1:1:1 / 2:2:1 / 3:3:1 came back as 1:1:1 / 2:1:1 /
3:1:1 — the static $n counter always restarted from the initial value
instead of persisting across calls.

Root cause: runStaticVar stored the default-value ZVal directly in
perClosure / perClass / v.z and then OffsetSet it into the function's
locals. When the default was a small integer (ZInt(0) etc.), ZInt.ZVal()
returned the shared cached wrapper — which the hash-table insert path
copies defensively (hashtable.go:325-336). The body's `$n++` then
mutated the *copy* in the hash table, not the stored original, so the
next call reloaded an unchanged initial value.

Fix: factor the initial-value computation into runStaticInitial(), which
Dup()s the result of def.Run (Dup always returns a fresh non-cached
ZVal). After this the stored ZVal and the hash-table entry are the same
pointer, so in-place mutations (doInc's v.Set etc.) are observable on
the next invocation.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

Coverage Stats

0 of 24 new or added lines in 1 file covered. (0.0%)

1 existing line in 1 file now uncovered.

2188 of 111924 relevant lines covered (1.95%)

70.38 hits per line