IJHack / QtPass / 24588315042

55%

Build Type

push

github

Committed by web-flow

Commit Message

fix: clear stale selection and update proxy filter on profile change (#1033)

When switching profiles or accepting config changes:

- `proxyModel.store` was never updated, so the filter (StoreModel::showThis)
  kept using the old profile's path — causing Util::getDir to compute
  `../../old-profile/subdir/` relative paths when adding new entries.
- Qt's delayed layout re-evaluation (doDelayedItemsLayout, triggered by
  setRootIndex) could reinstate a stale currentIndex, compounding the issue.
- Decrypted content, currentDir, clipboard text, passwordName, and the panel
  were not cleared, leaving stale data from the previous profile visible.

Fix:
- Add StoreModel::setStore() to update the filter path without reinitialising
  the source model.
- Call proxyModel.setStore() before mapFromSource so filtering is correct
  when the new root is mapped.
- Call deselect() to clear all stale UI state (currentDir, clipboard, panel,
  passwordName, edit/delete actions).
- Call ui->treeView->setCurrentIndex(QModelIndex()) after setRootIndex so
  the view's own currentIndexSet state is also cleared.
- Cache QtPassSettings::getPassStore() in a local variable to avoid
  redundant settings reads.
- Apply the same fixes to config() where the same staleness issues exist.

Closes #248

Coverage Stats

0 of 16 new or added lines in 2 files covered. (0.0%)

10 existing lines in 2 files now uncovered.

1176 of 5400 relevant lines covered (21.78%)

8.66 hits per line