IJHack / QtPass / 24585183540

55%

Build Type

push

github

Committed by web-flow

Commit Message

fix: set PASSWORD_STORE_* env vars and grey out pass-managed controls (#1032)

* fix: set PASSWORD_STORE_* env vars and grey out pass-managed controls (#265 #443)

- Pass::updateEnv() now sets PASSWORD_STORE_GENERATED_LENGTH and
  PASSWORD_STORE_CHARACTER_SET from QtPass settings so the pass binary
  honours the configured length and character set
- ConfigDialog::setGroupBoxState() disables password-generation
  controls (length, charset, pwgen options) when the pass binary is
  selected, since those are managed by pass in that mode
- passworddialog.ui spinBox_pwdLength maximum was already 255

Closes #265
Closes #443

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: isolate generateRandomPassword, boundedRandom, configIsValid tests from QSettings

Tests were reading isUsePwgen() and isUsePass() from the user's saved
QSettings, causing failures when those flags were enabled. Add RAII
guards to force the relevant settings to the expected values and restore
them on exit.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* fix: address code review findings on password generation controls and env vars

configdialog.cpp:
- setGroupBoxState() now disables all password-gen controls in pass mode
  and delegates to on_checkBoxUsePwgen_clicked() when restoring native
  mode, instead of blindly re-enabling everything
- on_checkBoxUsePwgen_clicked() guards against pass mode so usePwgen()
  called after usePass(true) in the constructor cannot re-enable the
  pwgen sub-controls

pass.cpp:
- Clamp passConfig.selected before array access to guard against
  out-of-range values in QSettings
- Remove stale PASSWORD_STORE_CHARACTER_SET env entry when charset
  becomes empty, instead of leaving the old value in place
- Add PASSWORD_STORE_GENERATED_LENGTH and PASSWORD_STORE_CHARACTER_SET
  to WSLENV so they propagate into the WSL environment

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

* refactor: replace duplicate inline rollback ... (continued)

Coverage Stats

28 of 46 new or added lines in 3 files covered. (60.87%)

1 existing line in 1 file now uncovered.

1176 of 5390 relevant lines covered (21.82%)

8.68 hits per line