Alan-Jowett / sonde / 24521007158

82%

push

github

test(e2e): implement 9 missing E2E test cases (#741)

* test(e2e): implement 9 missing E2E test cases

Add 9 of 15 missing E2E test cases from issue #717:

Protocol (aead_e2e_tests.rs):
- T-E2E-002: AEAD authentication round-trip (base case)
- T-E2E-040: Unknown node silent discard (0 responses)
- T-E2E-041: Sequence number enforcement in chunked transfer

Program distribution (aead_e2e_tests.rs):
- T-E2E-010: Full program update cycle with chunked transfer
- T-E2E-011: Program already current -> NOP (no re-download)

Command dispatch (aead_e2e_tests.rs):
- T-E2E-020: UPDATE_SCHEDULE via admin command queue
- T-E2E-021: REBOOT via admin command queue
- T-E2E-022: RUN_EPHEMERAL via admin command queue

BPF execution (e2e_tests.rs):
- T-E2E-080: Map access through full stack (persistence)

Deferred:
- T-E2E-082 (chunked transfer corruption) needs harness changes
  for frame injection
- T-E2E-050-054 (modem bridge) need mock modem transport (#115)

Closes #717

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* test(e2e): address review — map assertions and multi-chunk sequencing

- T-E2E-080: add map_storage assertions verifying map allocation
  with initial data and persistence across wake cycles
- T-E2E-041: use 1600-byte program to force multiple chunks (>= 2)
  so the sequence increment assertion is non-vacuous

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix(bpf): allow clippy::manual_checked_ops for BPF division semantics

BPF division-by-zero returns 0 per RFC 9669 section 5.2. The manual
`if x == 0 { 0 } else { a / x }` pattern is intentional and clearer
for this domain than `checked_div().unwrap_or(0)`. Allow the lint
on `execute_program` rather than changing the code.

Fixes clippy 1.95.0 `manual_checked_ops` lint.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Sig... (continued)

3 of 7 new or added lines in 1 file covered. (42.86%)

24003 of 29808 relevant lines covered (80.53%)

181.63 hits per line