Alan-Jowett / sonde / 24521211714

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(kicad): enforce constraints, fix SES safety, and add tests (#742)

* fix(kicad): enforce constraints, fix SES safety, and add tests

F-009 (High): Add post-placement proximity constraint validation.
  Components within a zone that exceed proximity_constraint_mm now
  produce Error::Placement with the violating pair and distance.

F-010 (Medium): Wire IR-3 routing_constraints into build_setup().
  Emits Default and Power net classes with trace widths from
  signal_traces and power_traces instead of placeholder values.

F-011 (Medium): SES import safety improvements.
  - Change unwrap_or(0) to Error::Ses for unmapped nets (prevents
    silent corruption by mapping unknown nets to net 0)
  - Add doc comments explaining DSN Y-up to KiCad Y-down negation

F-014 (Low): Replace hardcoded "2026-01-01" timestamp with a
  deterministic date derived from UuidGenerator seed bytes.

F-008 (High): Add 11 new integration tests:
  T-KE-010–014 (S-expression serialization), T-KE-027 (title block),
  T-KE-035 (zone proximity bounds), T-KE-040 (net classes),
  T-KE-052 (SES coordinate conversion), plus proximity violation
  and unmapped net error tests.

Test count: 23 -> 34 (48% increase).

Closes #718

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix(sonde-kicad): address 6 PR #742 review comments

- Fix 1: Change proximity validation from pairwise to anchor-based
- Fix 2: Filter copper pour entries from Power net class add_net
- Fix 3: Use minimum signal trace width for Default net class
- Fix 4: Fix deterministic_date_from_hash doc comment nibble indexing
- Fix 5: Derive title block date without consuming UUID counter slot
- Fix 6: Tighten ses_coordinate_y_negation test assertion

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

---------

Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-by: Alan Jowett <alan.jowett@microsoft.com>
Co-authored-... (continued)

Coverage Stats

110 of 117 new or added lines in 4 files covered. (94.02%)

4 existing lines in 3 files now uncovered.

24159 of 29911 relevant lines covered (80.77%)

205.48 hits per line