Alan-Jowett / sonde / 24483890787

82%

Build Type

push

github

Committed by web-flow

Commit Message

fix(pair): enrich PairingError variants with device context (PT-1215) (#726)

* fix(pair): enrich PairingError variants with device context (PT-1215)

Add device address context to 9 PairingError variants so error messages
satisfy PT-1215 AC1 (triggering input/parameters) and AC3 (stale pairing
hint for connection-dropped errors).

Variant changes:
- \ConnectionFailed(String)\ → \ConnectionFailed { device, reason }\
- \ConnectionDropped\ → \ConnectionDropped { device }\  (+ stale pairing hint)
- \MtuTooLow { negotiated, required }\ → adds \device: String\
- \Timeout { operation, duration_secs }\ → adds \device: Option<String>\
- \GattWriteFailed(String)\ → \GattWriteFailed { device, reason }\
- \GattReadFailed(String)\ → \GattReadFailed { device, reason }\
- \IndicationTimeout\ → \IndicationTimeout { device }\
- \DeviceNotFound\ → \DeviceNotFound { device }\
- \DeviceOutOfRange\ → \DeviceOutOfRange { device }\

Implementation:
- Add \ormat_device_address(&[u8; 6]) -> String\ helper
- Add \OptionalDevice\ newtype for clean \Option<String>\ display
- \BtleplugTransport\: store \connected_address\ on connect, clear on
  disconnect, thread through \post_connect_setup\ and \ind_characteristic\
- \AndroidBleTransport\: store address in \JniState\ via \Mutex\
- Update all construction sites in btleplug, android, loopback, mock
  transports, phase1, phase2, and e2e harness
- Add 7 unit tests covering format, display, and stale-pairing hint

Spec changes:
- Update \le-pairing-tool-design.md\ §8.1 PairingError enum
- Add 5 validation test cases T-PT-1215a–e to \le-pairing-tool-validation.md\

Closes #694

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* fix(pair): fix double-wrapped Result in Android connect()

The spawn_blocking closure returns Result<u16, PairingError>, so
.await.map_err(join_err)? yields Result<u16, PairingError>, not u16.
Add a second ? to unwrap the inner Res... (continued)

Coverage Stats

94 of 245 new or added lines in 7 files covered. (38.37%)

4 existing lines in 3 files now uncovered.

23808 of 29657 relevant lines covered (80.28%)

184.01 hits per line