Alan-Jowett / sonde / 24481506122

82%

push

github

test(modem): add BLE pairing state machine unit tests (#725)

* test(modem): add BLE pairing state machine unit tests

Add 6 bridge-level tests exercising realistic BLE pairing event
sequences via MockBle event injection:

- `ble_pairing_accept_full_flow` — MD-0416 AC1: PairingConfirm →
  operator accept → Connected forwarded
- `ble_pairing_reject_full_flow` — MD-0416 AC4: PairingConfirm →
  operator reject → Disconnected, no Connected ever sent
- `ble_pre_auth_gatt_write_buffered` — MD-0409 AC5: Recv emitted
  before Connected (buffered write flush order)
- `ble_pairing_timeout_disconnects` — MD-0414 AC4 / T-0622:
  PairingConfirm → no reply → Disconnected, no auto-reply
- `ble_idle_timeout_disconnects` — MD-0415: idle polls → Disconnected
- `ble_deferred_connected_with_buffered_write` — MD-0416 AC1+AC2
  combined: full flow with buffered GATT write and deferred Connected

Closes #693

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* test(modem): address review — stricter assertions and doc accuracy

- Use exact `assert_eq!` for `check_pairing_timeout_count` (not `>=`)
- Assert 2-frame decodes consume the entire TX buffer (no extra msgs)
- Clarify doc comments: bridge tests verify event forwarding/ordering,
  not ble.rs internal deferral/buffering behavior

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* style(modem): fix rustfmt formatting in BLE pairing tests

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* test(modem): assert full TX buffer consumption and clarify doc comments

- Assert `consumed == tx.len()` on all single-frame decodes to catch
  unexpected extra messages
- Rename timeout/idle tests to reflect what bridge-level tests actually
  validate (event forwarding, not timing behavior)
- Fix missing closing ... (continued)

182 of 193 new or added lines in 1 file covered. (94.3%)

23727 of 29484 relevant lines covered (80.47%)

185.09 hits per line