stacklok / toolhive / 23870867049

65%

Build Type

push

github

Committed by web-flow

Commit Message

Normalize proxyMode to always reflect effective HTTP protocol (#4468)

* Normalize proxyMode to always reflect effective HTTP protocol

proxyMode was only meaningful for stdio transports but could be set on
any transport, returning empty or misleading values to clients. This
caused confusion and required every client to implement conditional
logic via GetEffectiveProxyMode() to determine the actual protocol.

Add EffectiveProxyMode() to pkg/transport/types as the canonical typed
implementation, and NormalizeProxyMode() on RunConfig to apply it at
creation and load time. This ensures proxyMode is always the effective
value in persisted configs and API responses.

Also fixes the conflicting default in StdioTransport (SSE vs
streamable-http everywhere else).

Fixes #3296

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Regenerate swagger docs for updated ProxyMode description

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

17 of 18 new or added lines in 6 files covered. (94.44%)

4 existing lines in 2 files now uncovered.

53946 of 82382 relevant lines covered (65.48%)

64.42 hits per line