stacklok / toolhive / 23889040631

65%

Build Type

push

github

Committed by web-flow

Commit Message

Migrate session manager to DataStorage and add RestoreSession (#4464)

* Migrate session manager to DataStorage and add RestoreSession

Replace the *transportsession.Manager dependency in sessionmanager.Manager
with the DataStorage interface (introduced in split PR 1), enabling pluggable
session metadata storage (local or Redis) without coupling live session state
to the serialization layer.

Key changes:
- Add Exists() to the Storage interface with implementations for LocalStorage
  and RedisStorage; expose TTL() and Exists() on transportsession.Manager
- Add RestoreSession() to MultiSessionFactory (and decorating/mock impls);
  refactor makeSession → makeBaseSession so RestoreSession can reconstruct a
  live session from stored metadata without a bearer token
- Add RestoreHijackPrevention() in pkg/vmcp/session/internal/security to
  recreate the hijack-prevention decorator from stored hash/salt
- Rewrite sessionmanager.Manager to use DataStorage: node-local multiSessions
  sync.Map for hot-path lookups, singleflight-deduplicated RestoreSession on
  cache miss, and a background eviction loop that probes storage.Exists() to
  clean up expired MultiSession objects whose Redis TTL fired silently
- Replace *transportsession.Manager in discovery.Middleware with a
  MultiSessionGetter interface backed by the session manager; remove the 401
  for unknown sessions — the SDK now responds 404 via Validate()
- Wire server.go to create LocalSessionDataStorage and pass it to
  sessionmanager.New; route discovery middleware through vmcpSessionMgr

Closes: #4220

* fixes from review

---------

Co-authored-by: taskbot <taskbot@users.noreply.github.com>

Coverage Stats

387 of 500 new or added lines in 8 files covered. (77.4%)

44 existing lines in 7 files now uncovered.

54176 of 82726 relevant lines covered (65.49%)

64.03 hits per line