stacklok / toolhive / 23869204772

65%

Build Type

push

github

Committed by web-flow

Commit Message

Wire MCPServer to MCPTelemetryConfig with inline deprecation (#4482)

* Wire MCPServer to MCPTelemetryConfig with deprecation of inline telemetry

Add TelemetryConfigRef field to MCPServerSpec that references a shared
MCPTelemetryConfig resource, deprecating the inline Telemetry field.
CEL validation rejects specs that set both fields simultaneously.

The MCPServer controller resolves the reference during reconciliation,
tracks config hash changes for drift detection, sets status conditions,
generates OTEL environment variables (including sensitive header secret
injection), and watches MCPTelemetryConfig for cascade reconciliation.

The MCPTelemetryConfig controller now tracks referencing servers in
status.referencingServers, blocks deletion while workloads reference
the config, and watches MCPServer changes to keep the reference list
current.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Regenerate Helm CRD template via operator-manifests task

Run `task operator-generate` and `task operator-manifests` to update
the Helm-wrapped CRD template with the telemetryConfigRef field,
CEL validation rule, and telemetryConfigHash status field.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Address review: fix NotFound vs transient error handling

- getTelemetryConfigForMCPServer now returns (nil, nil) for NotFound
  so callers can distinguish "config missing" from "API unavailable"
- handleTelemetryConfig uses ConditionReasonTelemetryConfigRefError
  for transient API errors, reserving NotFound for genuinely missing
  resources
- Add ConditionReasonTelemetryConfigRefError constant
- deploymentForMCPServer logs at visible level when transient fetch
  fails after prior validation, with clear message about degradation
- Update tests for new (nil, nil) NotFound semantics

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Add integration tests for TelemetryConfigRef wire-up

Add envtest inte... (continued)

Coverage Stats

141 of 290 new or added lines in 8 files covered. (48.62%)

9 existing lines in 5 files now uncovered.

53897 of 82372 relevant lines covered (65.43%)

63.9 hits per line