stacklok / toolhive / 23824039865

65%

Build Type

push

github

Committed by web-flow

Commit Message

Add ObservedGeneration to MCPServer, MCPGroup, and MCPRegistry status (#4473)

* Add ObservedGeneration to MCPServer, MCPGroup, and MCPRegistry status

These three CRDs were missing the standard ObservedGeneration field
that all other operator CRDs already have. Without it, clients cannot
reliably determine whether the controller has processed the latest
spec change. This is required for CRD stabilization (KEP-1623).

Implements changes for issue #4469:
- Add ObservedGeneration int64 field to MCPServerStatus, MCPGroupStatus,
  and MCPRegistryStatus structs
- Set status.ObservedGeneration = object.Generation in each controller's
  reconcile loop
- Regenerate CRD manifests and Helm chart templates
- Add unit tests verifying ObservedGeneration is set correctly

* Replace unit tests with envtest integration tests

Move ObservedGeneration assertions from fake-client unit tests into
the existing envtest integration suites for MCPServer, MCPGroup, and
MCPRegistry. Integration tests exercise the full controller reconcile
loop against a real API server, providing stronger guarantees.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* Regenerate CRD API reference docs

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Coverage Stats

8 of 14 new or added lines in 3 files covered. (57.14%)

38 existing lines in 5 files now uncovered.

53031 of 80993 relevant lines covered (65.48%)

64.59 hits per line