1
92%
main: 92%

Ran 29 Mar 2026 10:36PM UTC

Files 935

Run time 23s

Badge

Embed ▾

Committed 29 Mar 2026 10:33PM UTC coverage: 61.287% (-0.01%) from 61.297%

Job # 23720685326.1

Build Type

push

github

Committed by

web-flow

Commit Message

fix: prevent corrupt addrinfo nodes on sockaddr allocation failure (#1112)

ares_append_ai_node() appended a node to the linked list before
allocating its sockaddr. If the sockaddr malloc failed, the function
returned ARES_ENOMEM but left a node on the list with ai_addr=NULL and
ai_family=0. Callers iterating the list could then dereference the NULL
ai_addr.

Additionally, the two address-family blocks used independent if
statements rather than else-if, so an invalid aftype silently returned
ARES_SUCCESS with a broken node on the list.

Fix by allocating the sockaddr first, then appending the node only on
success. Reject invalid address families with ARES_EFORMERR. Also fix a
duplicate ai_addr assignment (copy-paste leftover).

Signed-off-by: David Hotham (@dimbleby)

Coverage Stats

24852 of 40550 relevant lines covered (61.29%)

7842.46 hits per line

c-ares / c-ares / 23720685326 / 1
92%
main: 92%

README BADGES
x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 23720685326.1

c-ares / c-ares / 23720685326 / 1 92% main: 92%

README BADGES x

Markdown

Textile

RDoc

HTML

Rst

Source Files on job 23720685326.1

c-ares / c-ares / 23720685326 / 1
92%
main: 92%

README BADGES
x