Alan-Jowett / sonde / 23503026260

82%

push

github

feat(modem): add operational logging requirements and implementation (#460)

* fix(node): remove RngHealthCheckFailed match arm from firmware binary

The RngHealthCheckFailed enum variant was removed during the PR #418
merge resolution -- RNG health-check failure now returns
WakeCycleOutcome::Sleep (graceful degradation). The bin/node.rs match
arm referencing the removed variant was auto-merged from the PR branch
and breaks the ESP32 firmware build.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* feat(modem): add operational logging requirements and implementation

Add MD-0500 through MD-0504 requirements for operational logging of
ESP-NOW frames, BLE lifecycle events, BLE GATT writes, USB-CDC message
relay, and BLE pairing events.

Update modem-design.md section 14 (Diagnostics) with expanded log level
table and new subsection 14.5 documenting the logging approach using
ESP-IDF \log\ crate macros.

Add validation test cases T-0700 through T-0704 covering the key
observable log events.

Implementation changes in \ridge.rs\:
- Add \msg_type_label()\ helper for human-readable message type names
- Log ESP-NOW received frames at INFO (peer_mac, len, rssi)
- Log ESP-NOW sent frames at INFO (peer_mac, len)
- Log USB-CDC messages sent/received at DEBUG (msg_type, len)

BLE logging in \le.rs\ was already comprehensive — no code changes
needed there.

Partial fix for #459 (modem component).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* style: fix formatting in modem logging

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* fix: address review findings for modem operational logging

- Change \Radio::send\ to return \ool\ so callers can log send
  result (MD-0500 AC#2)
- Update \EspNowDriver::send\, \ChannelRadio::send\, and
  \MockRadio::send\ implementations to return success/failure
- Fix \handle_send_frame\ to log send result a... (continued)

18 of 73 new or added lines in 2 files covered. (24.66%)

21463 of 25084 relevant lines covered (85.56%)

163.84 hits per line