Alan-Jowett / sonde / 23503031821

82%

Build Type

push

github

Committed by web-flow

Commit Message

feat(pair): add diagnostic logging requirements and implementation (#461)

* feat(pair): add diagnostic logging requirements and implementation

Add PT-1207 through PT-1212 requirements for diagnostic logging in the
BLE pairing tool. These cover BLE scan events, connection lifecycle,
GATT write/indication events, phase transitions, LESC pairing status,
and error context logging.

Spec changes:
- requirements: new section 15 (Diagnostic logging) with six requirements
- design: new section 14 (Diagnostic logging) with architecture, levels,
  structured fields, and security invariant; traceability updated
- validation: six new test cases (T-PT-1207 through T-PT-1212) with
  traceability appendix entries

Code changes:
- discovery.rs: add \	racing::debug!\ for scan start/stop, device
  discovered (name, address, rssi, service_uuids), and stale eviction
- btleplug_transport.rs: add \debug!\ for GATT indication reception
  (characteristic, len)
- phase2.rs: add \debug!\ for MTU after node connection, node error
  responses, and provision failure status

Partial fix for #459 (pairing tool component)

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Alan Jowett <alan.jowett@microsoft.com>

* Address review findings for PR #461

- Rename uuids field to services in DeviceScanner::start to match
  design doc 14.3 and BtleplugTransport::start_scan (PT-1207)
- Add address field to connection log in provision_node (PT-1208)
- Remove indication bytes from trace-level examples to align with
  14.4 security invariant forbidding raw payload logging (PT-1209)
- Remove redundant service_uuids from scan event field catalog and
  update PT-1212 error context description to reflect debug log
  events with structured fields
- Update T-PT-1209 assertion to include characteristic UUID field

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

* Address iteration 2 review findings

- Sanitize and truncate peer-controlled diag... (continued)

Coverage Stats

26 of 28 new or added lines in 4 files covered. (92.86%)

1 existing line in 1 file now uncovered.

21485 of 25108 relevant lines covered (85.57%)

163.69 hits per line