kubeovn / kube-ovn / 23405076297

27%

push

github

fix(controller): prevent dual-stack cross-deletion of local DNS cache policy routes (#6497)

* fix(controller): use address-family filter in addPolicyRouteForLocalDNSCacheOnNode to prevent dual-stack cross-deletion

In dual-stack environments, addPolicyRouteForLocalDNSCacheOnNode used
GetLogicalRouterPoliciesByExtID which only filtered by "node" key,
returning policies from ALL address families. This caused each af call
to delete the other af's policies — e.g., the af=4 call would delete
af=6 policies and vice versa, resulting in only the last-processed
address family having working local DNS cache routes.

Replace GetLogicalRouterPoliciesByExtID with ListLogicalRouterPolicies
using the full externalIDs map (which includes "address-family"), making
it consistent with deletePolicyRouteForLocalDNSCacheOnNode. Also remove
the now-redundant manual ExternalIDs filter in the loop since
ListLogicalRouterPolicies already handles this filtering.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* fix(test): remove brittle line-number references from test comments

Address Copilot review feedback: replace hard-coded line number
references (L1096, L1102-1116, node.go:1087) with function/behavior
descriptions that won't drift as the file changes.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

1 of 2 new or added lines in 1 file covered. (50.0%)

13070 of 55159 relevant lines covered (23.7%)

0.28 hits per line