kubeovn / kube-ovn / 23404772237

27%

push

github

fix(controller): handle npsLister.List error in checkAndUpdateNodePortGroup (#6498)

* fix(controller): handle npsLister.List error in checkAndUpdateNodePortGroup

Previously the error from npsLister.List was silently discarded. If the
lister ever returned an error, networkPolicyExists would be false and
the else branch would delete all node ACLs, removing network policy
protection. Check the error and return early instead.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

* test(controller): add unit test for npsLister error in checkAndUpdateNodePortGroup

Add a test that verifies checkAndUpdateNodePortGroup returns an error
when npsLister.List fails, instead of proceeding to delete node ACLs.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

5 of 5 new or added lines in 1 file covered. (100.0%)

13032 of 55161 relevant lines covered (23.63%)

0.28 hits per line