kubeovn / kube-ovn / 23406077511

27%

push

github

fix(controller): fix variable shadowing in cleanDuplicatedChassis (#6496)

* fix(controller): fix variable shadowing in cleanDuplicatedChassis that prevented duplicate chassis cleanup

L732 used := instead of = for err, creating a new block-scoped variable
that shadowed the outer err (always nil). This caused:
1. The error log at L735 to always print nil
2. errors.Is(nil, ErrOneNodeMultiChassis) to always be false, so
   DeleteChassisByHost was never called
3. The function to always return nil, defeating retryDelDupChassis retry

Also fixed: after successful deletion, return nil instead of the original
ErrOneNodeMultiChassis error to avoid unnecessary retries.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* test(controller): add unit tests for cleanDuplicatedChassis

Cover all branches: single chassis (no-op), multi-chassis cleanup
success, cleanup failure, and non-multi-chassis error propagation.
Also add MockSbClient to fake controller test infrastructure.

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* chore(controller): fix import order in node_test.go

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>

---------

Signed-off-by: Mengxin Liu <liumengxinfly@gmail.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

11 of 11 new or added lines in 1 file covered. (100.0%)

13086 of 55161 relevant lines covered (23.72%)

0.28 hits per line