f-dangel / curvlinops / 23394684275

91%

push

github

[REF] **Backward-incompatible:** Migrate params from `list[Parameter]` to `dict[str, Tensor]` (#283)

* [REF] Migrate params from list[Parameter] to dict[str, Tensor]

All operators now accept params as dict[str, Tensor] instead of
list[Parameter]. Pass dict(model.named_parameters()) instead of
list(model.parameters()).

- Simplify _EmpiricalRiskMixin.__init__: remove list/dict branching,
  SUPPORTS_FUNCTIONAL flag, identify_free_parameters call
- Update all operator type hints to dict[str, Tensor]
- Update _prepare_params_and_model to accept dict for Modules
- Update conftest.py to provide dict params
- Update all test files to use dict params

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* [FIX] Fix doctest iterating over dict params keys instead of values

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* [FIX] Restore benchmark JSON files accidentally removed

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* [FIX] Restore original PDF files modified by doc build

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* [FIX] Remove dead code and fix dict iteration bug in model merging example

- Remove `identify_free_parameters` (no longer called anywhere)
- Remove `_make_params_dict` and list path from `_prepare_params_and_model`
- Fix `example_model_merging.py` iterating dict keys instead of values

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* [FIX] Update stale type annotations from list[Tensor] to dict[str, Tensor]

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* [FIX] Update stale docstrings referencing list params

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* [FIX] Update remaining stale type annotations and docstrings for dict params

- functorch.py: narrow params from list|dict to dict, update docstrings
- ggn_diagonal.py, computers/ggn_diagonal.py: update params docstrings
- tes... (continued)

41 of 43 new or added lines in 11 files covered. (95.35%)

2376 of 2600 relevant lines covered (91.38%)

0.91 hits per line