f-dangel / curvlinops
92%

DEFAULT BRANCH: main
Repo Added
Token 1sGfst1y1afWR4uH04KDBU86hcNIONSz6 regen
Build 1845 Last
Files 53
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

LAST BUILD ON BRANCH main
branch: SELECT
CHANGE BRANCH
x
Sync Branches

coverage: 92.348% (+0.2%) from 92.163%
28752829889

push

github

web-flow 
[ADD] Detect Linear weights/biases reused across reshape-wrapped matmuls (#308)

* [ADD] Detect Linear weights/biases reused across reshape-wrapped matmuls

Make the FX layer-IO matcher robust to graphs that wrap a Linear's matmul in
transparent, last-dim-preserving shape ops and add the bias only after them --
e.g. Taylor-mode/jet graphs that emit `mm -> _unsafe_view -> squeeze -> add(bias)`
and reuse one weight across several such matmuls (one per Taylor coefficient).

- linear.py: traverse last-dim-preserving transparent ops (view/_unsafe_view/
  reshape/squeeze/unsqueeze) when linking a bias `add` to its matmul, on both the
  weight and bias sides, keeping the two infos identical so they deduplicate.
  Reshapes that alter the last (feature) dimension are still rejected.
- verification.py: treat a usage path as covered when a detected path is a prefix
  of it (the usage reached a matched layer output and merely continues downstream),
  not only when the usage is a prefix of a detected path. Without this, a weight
  reused in matmuls of uneven reshape depth was spuriously reported as uncovered.

Existing behavior is unchanged for standard nn.Module graphs (io_collector and
computer test suites pass). No new public API.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>

* [TEST] Cover reshape-wrapped bias detection in the FX layer-IO matcher

Add tests for the pattern the previous commit enables -- a Linear whose bias is
added after transparent, last-dim-preserving reshape ops, and a single weight
reused across matmuls of uneven reshape depth (as emitted by collapsed
Taylor-mode / jet graphs, one matmul per Taylor coefficient).

- test_param_io.py:
  - test_bias_add_through_transparent_reshapes: bias reached through
    `mm -> unsqueeze -> squeeze -> add(bias)` is linked to its layer.
  - test_weight_reused_across_reshape_wrapped_matmuls: one weight over three
    coefficient matmuls (only the forward one biased, via a reshape cha... (continued)

34 of 36 new or added lines in 1 file covered. (94.44%)

1 existing line in 1 file now uncovered.

2667 of 2888 relevant lines covered (92.35%)

0.92 hits per line

Relevant lines Covered
2888 RELEVANT LINES 2667 COVERED LINES
0.92 HITS PER LINE
Source Files on main

Recent builds

Builds Branch Commit Type Ran Committer Via Coverage
28752829889 main [ADD] Detect Linear weights/biases reused across reshape-wrapped matmuls (#308) * [ADD] Detect Linear weights/biases reused across reshape-wrapped matmuls Make the FX layer-IO matcher robust to graphs that wrap a Linear's matmul in transparent, ... push web-flow github
92.35
28752208399 fx-kfac-reshape-wrapped-bias [TEST] Cover reshape-wrapped bias detection in the FX layer-IO matcher Add tests for the pattern the previous commit enables -- a Linear whose bias is added after transparent, last-dim-preserving reshape ops, and a single weight reused across mat... Pull #308 f-dangel github
92.35
28752210288 fx-kfac-reshape-wrapped-bias Merge bffde1af3 into 5057b73fe Pull #308 web-flow github
92.35
28751974076 fx-kfac-reshape-wrapped-bias Merge 0fb6e7b2c into 5057b73fe Pull #308 web-flow github
92.35
28751973125 fx-kfac-reshape-wrapped-bias [TEST] Cover reshape-wrapped bias detection in the FX layer-IO matcher Add tests for the pattern the previous commit enables -- a Linear whose bias is added after transparent, last-dim-preserving reshape ops, and a single weight reused across mat... push f-dangel github
92.35
28751938269 fx-kfac-reshape-wrapped-bias Merge 8048d25b4 into 5057b73fe Pull #308 web-flow github
92.35
28751937083 fx-kfac-reshape-wrapped-bias [TEST] Cover reshape-wrapped bias detection in the FX layer-IO matcher Add tests for the pattern the previous commit enables -- a Linear whose bias is added after transparent, last-dim-preserving reshape ops, and a single weight reused across mat... push f-dangel github
92.35
28680826312 fx-kfac-reshape-wrapped-bias [TEST] Cover reshape-wrapped bias detection in the FX layer-IO matcher Add tests for the pattern the previous commit enables -- a Linear whose bias is added after transparent, last-dim-preserving reshape ops, and a single weight reused across mat... Pull #308 f-dangel github
92.35
28680779559 fx-kfac-reshape-wrapped-bias [TEST] Cover reshape-wrapped bias detection in the FX layer-IO matcher Add tests for the pattern the previous commit enables -- a Linear whose bias is added after transparent, last-dim-preserving reshape ops, and a single weight reused across mat... push f-dangel github
92.35
28680781228 fx-kfac-reshape-wrapped-bias Merge d4691660f into 5057b73fe Pull #308 web-flow github
92.35
See All Builds (1551)