RobotWebTools / rclnodejs / 23042190029

86%

push

github

Prevent CI hangs from unbounded subprocess waits (#1434)

Two intermittent CI hang issues were identified:

1. test-message-generation-bin.js: The before() hook runs spawnSync for npm init, npm pack, and npm install (full native rebuild from tarball) with no timeout. If any of these hangs (network issue, lock contention, slow arm64 runner), mocha blocks indefinitely until the GitHub Actions runner is reclaimed, producing a "context canceled" error with no useful diagnostics. Fixed by adding timeout to all spawnSync calls (60s for init, 120s for pack/scripts, 300s for install).

2. test/electron/run_test.js: The parent process spawns Electron via xvfb-run and waits for the close event. If the Electron child process or lingering DDS/FastDDS background threads don't terminate cleanly (due to async app.quit() racing with process.exit(), or xvfb-run holding stdio pipes open), the parent hangs forever. Fixed by adding a 30-second kill timeout that forcibly terminates the child if it doesn't exit after the test completes.

Fix: #1433

1405 of 1770 branches covered (79.38%)

Branch coverage included in aggregate %.

2876 of 3209 relevant lines covered (89.62%)

450.3 hits per line