f-dangel / curvlinops / 23174555294

91%

Build Type

push

github

Committed by web-flow

Commit Message

[REF] Simplify `make_functional_call`: drop redundant frozen param capture (#266)

* [REF] Simplify make_functional_call: drop redundant frozen param capture

functional_call already uses the module's own state as fallback for
parameters and buffers not in the override dict, so explicitly capturing
frozen parameters and buffers is unnecessary. Remove the frozen dict
logic and the now-unused free_param_names/param_names arguments from
make_functional_call, make_functional_model_and_loss,
make_functional_flattened_model_and_loss, and all make_batch_* wrapper
functions.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* [REF] Collapse multi-line calls where trailing commas are no longer needed

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* [REF] Replace make_functional_model_and_loss with separate helpers

Split into make_functional_call (model) and make_functional_loss (loss).
Callers that only needed the model functional (jacobian, ggn_diagonal,
ggn mc) now call make_functional_call directly, avoiding a dummy loss.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* [FIX] Restore per-block freezing in block-diagonal Hessian

The block-diagonal HVP needs per-block functions where non-block
parameters are explicitly frozen (detached). Passing only block params
to functional_call leaves non-block module params with requires_grad,
which can interfere with jacrev/jvp tracing.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* [DOC] Add changelog entry for make_functional_call simplification

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

* trigger CI

---------

Co-authored-by: f-dangel <felix.dangel@concordia.ca>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Run Details

32 of 32 new or added lines in 7 files covered. (100.0%)

21 existing lines in 5 files now uncovered.

2434 of 2663 relevant lines covered (91.4%)

0.91 hits per line