NVIDIA / holodeck / 23063488054

51%

push

github

feat: add public subnet and NAT gateway for cluster mode (#723)

* feat: add public subnet and NAT gateway for cluster mode

Cluster mode now creates two subnets:
- Private (10.0.0.0/24): all nodes, routes through NAT GW
- Public (10.0.1.0/24): NAT gateway and NLB only

EIP is cleaned up if NAT gateway creation fails (D4).

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: add delete-path cleanup for NAT GW, EIP, public subnet/RT

Address Distinguished Engineer review findings for PR #723:

R1: Remove misleading MapPublicIpOnLaunch call from createPublicSubnet.
NAT Gateway gets its public IP from the EIP allocation, not from subnet
attributes. No instances are launched in the public subnet.

R2 (CRITICAL): Add cleanup for NAT Gateway, Elastic IP, public route
table, and public subnet in deleteVPCResources. Without this, every
cluster deployment leaks billable AWS resources (~$0.045/hr per NAT GW).
Cleanup order respects AWS dependency constraints: NAT GW first (async
delete with polling), then EIP, then public RT, then public subnet.

R3: Fix pre-existing bug in createRouteTable — missing cancelLoading
call on CreateRoute failure. Matches the pattern used by
createPublicRouteTable and createPrivateRouteTable.

Signed-off-by: Eduardo Arango <earango@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: add missing EC2Client interface methods to shared mock

Add stub implementations for AllocateAddress, ReleaseAddress,
CreateNatGateway, DeleteNatGateway, DescribeNatGateways, and
ModifySubnetAttribute to the shared MockEC2Client in pkg/testutil/mocks.
These methods were added to the EC2Client interface but not to the shared
mock, breaking pkg/cleanup tests.

Signed-off-by: Eduardo Arango <earango@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: remove unused containsSubstringHelper function

Fix golangci-lint unused function violation in delete_test.go.
... (continued)

235 of 303 new or added lines in 3 files covered. (77.56%)

3162 of 6186 relevant lines covered (51.12%)

0.58 hits per line