NVIDIA / holodeck / 23063499190

51%

Build Type

push

github

Committed by web-flow

Commit Message

feat: add Transport abstraction for SSH connections (#724)

* feat: add Transport abstraction for SSH connections

Introduce Transport interface so each provider controls how SSH
connections are established. DirectTransport for single-node and SSH
provider. SSMTransport for AWS cluster mode with retry-based dial (D1).
Provisioner unchanged — just receives working connections.

- Transport interface with Dial() and Target() methods
- DirectTransport: TCP dial to host:22 (existing behavior)
- SSMTransport: AWS SSM port forwarding with exponential backoff retry
- Provisioner gets functional option WithTransport()
- NodeInfo gets InstanceID and Transport fields
- Backwards compatible: nil transport falls back to DirectTransport

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: wire Transport into SSH connection path and add cleanup

Address Distinguished Engineer review findings for PR #724:

B1 (BLOCKING): connectOrDie() now uses transport.Dial() + ssh.NewClientConn()
when a Transport is provided, instead of ignoring the transport and calling
ssh.Dial("tcp", ...) directly. All reconnection paths (waitForNodeReboot,
provision) pass p.transport through.

B2 (BLOCKING): installK8sPrereqs() and GetClusterHealth() now use
transportOptsForNode() to pass transport options to New().

R1: SSMTransport.Dial() is now idempotent — closes any existing session
before starting a new one.

R2: Transport interface includes Close() method. DirectTransport has a
no-op Close(). SSMTransport.Close() terminates the SSM process.

R3: SSM stderr is captured in a bytes.Buffer and included in error
messages for diagnostics.

R4: GetClusterHealth() builds transport options from node info in
environment status.

Signed-off-by: Eduardo Arango <earango@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: check error return values in transport tests

Fix golangci-lint errcheck violations for ln.Close() and conn.Close()
in... (continued)

Run Details

36 of 163 new or added lines in 3 files covered. (22.09%)

1 existing line in 1 file now uncovered.

3205 of 6323 relevant lines covered (50.69%)

0.57 hits per line