NVIDIA / holodeck / 23063445377
51%

DEFAULT BRANCH: main
Ran
Jobs 1
Files 37
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst
coverage: 49.567%. Remained the same
23063445377

push

github

web-flow 
fix: verify API server against local IP before switching to NLB (#721)

* fix: verify API server against local IP before switching to NLB

HA cluster kubeadm init succeeded but kubectl version failed because
admin.conf pointed at the NLB before its health checks passed. Verify
the API server using the local private IP first, then switch to the
NLB endpoint.

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

* fix: move NODE_PRIVATE_IP and NLB switch outside init guard

Address 4 issues from Distinguished Engineer review:

1. BLOCKING: NODE_PRIVATE_IP and INIT_ENDPOINT were scoped inside
   the `if [[ ! -f admin.conf ]]` block but used outside it for
   API verification and NLB switch — would crash on re-run.
   Moved both assignments before the init guard.

2. Escape dots in INIT_ENDPOINT for sed regex safety — IP addresses
   contain literal dots that are regex metacharacters.

3. Move NLB switch block to after Calico installation per design:
   NLB health checks require a working CNI to pass. Previous
   position was before Calico, violating the design contract.

4. Add test assertion verifying Calico installation happens before
   NLB endpoint switch.

Signed-off-by: Eduardo Arango <earango@nvidia.com>
Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>

---------

Signed-off-by: Carlos Eduardo Arango Gutierrez <eduardoa@nvidia.com>
Signed-off-by: Eduardo Arango <earango@nvidia.com>

2916 of 5883 relevant lines covered (49.57%)

0.56 hits per line

Jobs
ID Job ID Ran Files Coverage
1 23063445377.1 37
49.57
 GitHub Action Run
Source Files on build 23063445377