• Home
  • Features
  • Pricing
  • Docs
  • Announcements
  • Sign In

RobotWebTools / rclnodejs / 22705943136
86%

Build:
DEFAULT BRANCH: develop
Ran 05 Mar 2026 07:02AM UTC
Jobs 1
Files 50
Run time 1min
Badge
Embed ▾
README BADGES
x

If you need to use a raster PNG badge, change the '.svg' to '.png' in the link

Markdown

Textile

RDoc

HTML

Rst

05 Mar 2026 06:47AM UTC coverage: 85.838% (+0.4%) from 85.481%
22705943136

push

github

web-flow
Fix bugs in examples and electron demos (#1414)

This PR fixes small but user-facing issues in the JavaScript examples and Electron demos, improving correctness of sample code and shutdown/cleanup behavior.

**Changes:**

**example/topics/publisher/publisher-qos-example.js**
- Fix typo `qos.hitory` → `qos.history`; the misspelled property silently created a non-existent field, so the history policy was never actually configured

**example/actions/action_client/action-client-example.js**
- Fix undefined variable `status` → `goalHandle.status` in the goal failure log message; the original code would throw a `ReferenceError` when a goal failed

**electron_demo/manipulator/main.js**
- Fix resource leak: store the publishing `setInterval` return value in `publishingInterval` and clear it on app shutdown; previously the interval ID was discarded, making cleanup impossible

**electron_demo/turtle_tf2/main.js**
- Fix incorrect `rclnodejs.shutdown()` usage: call it once globally instead of once per node in a `forEach` loop; `shutdown()` tears down the entire ROS2 context, so calling it multiple times risks context corruption

Fix: #1413

1387 of 1754 branches covered (79.08%)

Branch coverage included in aggregate %.

2868 of 3203 relevant lines covered (89.54%)

450.07 hits per line

Uncovered Existing Lines

Lines Coverage ∆ File
2
75.89
0.3% lib/parameter.js
2
93.33
14.02% lib/time_source.js
5
87.23
-3.68% lib/service.js
19
79.74
0.18% lib/action/client.js
Jobs
ID Job ID Ran Files Coverage
1 22705943136.1 05 Mar 2026 07:02AM UTC 50
85.84
GitHub Action Run
Source Files on build 22705943136
  • Tree
  • List 50
  • Changed 7
  • Source Changed 7
  • Coverage Changed 6
Coverage ∆ File Lines Relevant Covered Missed Hits/Line Branch Hits Branch Misses
  • Back to Repo
  • Github Actions Build #22705943136
  • e020c1fc on github
  • Prev Build on develop (#22704446385)
  • Next Build on develop (#22708647586)
STATUS · Troubleshooting · Open an Issue · Sales · Support · CAREERS · ENTERPRISE · START FREE · SCHEDULE DEMO
ANNOUNCEMENTS · TWITTER · TOS & SLA · Supported CI Services · What's a CI service? · Automated Testing

© 2026 Coveralls, Inc