RobotWebTools / rclnodejs / 22705943136

86%

push

github

Fix bugs in examples and electron demos (#1414)

This PR fixes small but user-facing issues in the JavaScript examples and Electron demos, improving correctness of sample code and shutdown/cleanup behavior.

**Changes:**

**example/topics/publisher/publisher-qos-example.js**
- Fix typo `qos.hitory` → `qos.history`; the misspelled property silently created a non-existent field, so the history policy was never actually configured

**example/actions/action_client/action-client-example.js**
- Fix undefined variable `status` → `goalHandle.status` in the goal failure log message; the original code would throw a `ReferenceError` when a goal failed

**electron_demo/manipulator/main.js**
- Fix resource leak: store the publishing `setInterval` return value in `publishingInterval` and clear it on app shutdown; previously the interval ID was discarded, making cleanup impossible

**electron_demo/turtle_tf2/main.js**
- Fix incorrect `rclnodejs.shutdown()` usage: call it once globally instead of once per node in a `forEach` loop; `shutdown()` tears down the entire ROS2 context, so calling it multiple times risks context corruption

Fix: #1413

1387 of 1754 branches covered (79.08%)

Branch coverage included in aggregate %.

2868 of 3203 relevant lines covered (89.54%)

450.07 hits per line