RobotWebTools / rclnodejs / 22704446385

86%

push

github

Fix bugs in rosidl_gen and index.js, add tests (#1412)

This PR fixes a couple of correctness issues in message generation and generator version detection, and adds targeted tests to prevent regressions in `rosidl_gen` primitive type initialization.

**Changes:**

**index.js**
- Fix file descriptor leak in `getCurrentGeneratorVersion()`: replaced `fs.open()` followed by nested `fs.readFile()` with a single `fs.readFile()` call, eliminating the unclosed fd when the file exists
- Add `try/catch` around `JSON.parse()` to properly reject on malformed JSON instead of throwing an unhandled exception

**rosidl_gen/primitive_types.js**
- Fix operator precedence bug in `initString()`: `(!str) instanceof Buffer` always evaluated to `false` (negating `str` first, then checking if `true`/`false` is an instance of `Buffer`); corrected to `!(str instanceof Buffer)` so the type guard works as intended
- Same fix for the `(!str) instanceof StringRefStruct` check in the `own=false` branch

**rosidl_gen/packages.js**
- Fix TOCTOU race in `generateMsgForSrv()`: replaced `existsSync()` + `mkdirSync()` with `mkdirSync(path, { recursive: true })`, which is atomic and won't throw if the directory already exists

**test/test-primitive-types.js** *(new)*
- Add 9 unit tests for `initString()` covering both `own=true` and `own=false` branches: rejects invalid types (number, string, null, undefined, Buffer-when-struct-expected) and correctly initializes a valid `StringRefStruct`

Fix: #1411

1380 of 1755 branches covered (78.63%)

Branch coverage included in aggregate %.

2859 of 3204 relevant lines covered (89.23%)

448.55 hits per line