lsm / neokai / 22554055701

84%

push

github

test(e2e): fix E2E tests for Lobby UI and session creation changes (#171)

* test(e2e): fix E2E tests for Lobby UI and session creation changes

Update all E2E tests to match the new Lobby component UI:
- Replace "NeoKai"/"Welcome to NeoKai" headings with "Neo Lobby" (h2)
- Replace button click session creation with createSessionViaUI() (RPC-based)
  since "New Session" now opens a modal requiring workspace path
- Rewrite WebSocket disconnect/reconnect helpers to use ConnectionManager
- Fix offline detection to use NavRail's Daemon indicator button
- Fix model-selection test to verify model persistence via switcher title
- Fix slash-cmd tests: exact match for "help" button, reliable click-outside
- Fix mobile touch target threshold for Lobby's icon-only button
- Fix error-scenarios to verify disabled state during disconnect

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test(e2e): fix click-outside and worktree-git-operations tests

- Fix slash-cmd click-outside test: use native Playwright click on heading
  instead of synthetic mousedown dispatch (fails in CI)
- Fix worktree-git-operations: use createSessionViaUI and update heading text

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* ci: enable Coveralls finalization and coverage quality gate

Re-enable the previously disabled coveralls-finalize and coverage-gate
CI jobs. Coverage uploads are already working; this enables the
finalization step and the quality gate that enforces minimum 30%
coverage and max 2% regression.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* test(e2e): fix remaining E2E test failures and move LLM tests

- message-flow: replace manual New Session button clicks with createSessionViaUI
- settings-modal: fix h2:has-text("Settings") strict mode violation (2 elements)
- auth-error-scenarios: update to check daemon status indicator instead of removed auth text
- thinking-level-selector: fix text=Connected -> aria-label for daemon status
- inter... (continued)

2561 of 3019 branches covered (84.83%)

Branch coverage included in aggregate %.

20300 of 23926 relevant lines covered (84.84%)

266.35 hits per line