Idrinth / habit-evaluator / 22070782821

40%

push

github

Fix positivityDiaryCard visibility with scroll reset and reselection guard (#425)

Two issues caused the Maestro test assertion on positivityDiaryCard to fail:

1. Scroll position preserved: When the diary navigation page was scrolled
   down to "Your Medications" and the user navigated away then back, the
   ScrollView kept its scroll position, leaving positivityDiaryCard
   off-screen at the top. Fixed by adding scrollToTop() to
   DiaryNavigationFragment and calling it in onPageSelected(PAGE_DIARY).

2. Reselection listener conflict: The OnItemReselectedListener added in
   commit e82a72f interfered with programmatic navigation to diary
   sub-pages. When navigating to PAGE_POSITIVITY_DIARY, onPageSelected
   called setSelectedItemId(nav_diary) which triggered the reselected
   listener (since diary was already selected), bouncing back to the
   diary hub. Fixed by adding isSyncingBottomNav flag that suppresses
   the reselected listener during onPageSelected callbacks.

https://claude.ai/code/session_01UxCnPEgXBydCu2tCY3FJqE

Co-authored-by: Claude <noreply@anthropic.com>

2782 of 7042 branches covered (39.51%)

Branch coverage included in aggregate %.

9426 of 20290 relevant lines covered (46.46%)

2.24 hits per line