Idrinth / habit-evaluator / 21971550702

40%

push

github

Extract notification logic into flavor-specific NotificationHelper and add POST_NOTIFICATIONS permission handling (#384)

* Extract notification logic into flavor-specific NotificationHelper and add POST_NOTIFICATIONS permission handling

The NotificationChannel creation is now in flavor-specific source sets:
- modern (API 26+): creates channel unconditionally
- legacy (API 21+): guards with Build.VERSION.SDK_INT >= O check

Both flavors gain POST_NOTIFICATIONS runtime permission handling for
API 33+, requested when any reminder is enabled in settings. Without
this, notifications silently fail on Android 13+ devices.

https://claude.ai/code/session_01XixYUToNd4atuyNUxQttHB

* Extract POST_NOTIFICATIONS permission into handler classes

Replace inline version checks with a NotificationPermissionHandler
interface and two implementations:
- PreApi33PermissionHandler: no-op, always grants permission
- Api33PermissionHandler: checks POST_NOTIFICATIONS at runtime

NotificationHelper.permissionHandler() selects the right one based
on the device API level.

https://claude.ai/code/session_01XixYUToNd4atuyNUxQttHB

* Rename flavors to Android version names and add tiramisu (API 33+)

Rename legacy→lollipop (API 21+), modern→oreo (API 26+), and add a
new tiramisu flavor (API 33+). Each flavor's NotificationHelper now
directly returns the right NotificationPermissionHandler without a
runtime version check:
- lollipop/oreo: PreApi33PermissionHandler (no-op)
- tiramisu: Api33PermissionHandler (real permission check)

Updates CI and release workflows to build all three flavors.

https://claude.ai/code/session_01XixYUToNd4atuyNUxQttHB

* Make lollipop NotificationHelper.ensureNotificationChannel a no-op

Devices running API 26+ install the oreo flavor, so the lollipop
flavor only runs on API 21–25 where notification channels do not
exist. The API 26 guard was dead code.

https://claude.ai/code/session_01XixYUToNd4atuyNUxQttHB

---------

Co-authored-by: Claude <norepl... (continued)

1968 of 6167 branches covered (31.91%)

Branch coverage included in aggregate %.

6887 of 18087 relevant lines covered (38.08%)

1.77 hits per line