kobotoolbox / kpi / 21400350437

81%

master: 76%

push

github

refactor(formBuilder): migrate editableForm and connected files to TypeScript DEV-1520 (#6588)

### 📣 Summary

Internal refactor of piece(s) of code that connects Form Builder
(Backbone x CoffeeScript app) with the rest of the UI (React x
JavaScript x TypeScript app).

### 💭 Notes

The touched parts are the connection between Backbone and React, so I've
started with migrating `editableForm.js` (now `EditableForm.tsx`) and
then all the related parts, mainly:
- `cascadeMixin.js` - integrated into `EditableForm.tsx`
- `formEditors.tsx` are using EditableForm in a new way (EditableForm is
no longer a React mixin)
- `formBuilderUtils.tsx`
- `_xlform.init.coffee` 
- is being imported into `EditableForm.tsx` and is itself a sort of root
gathering of all coffee code
- to make it useful (i.e. avoid it being `any`) I've added `.d.ts` file
for it and for all the files that it is importing etc. (this is the main
reason this PR adds so much LOC)
- the types were build partially by hand and partially with AI, because
I don't really really need them being nice, I just need them be Good
Enough™ and I feel they are
- `surveyScope.tsx` is a companion piece to `EditableForm.tsx` and
Backbone code is using it
- Improved types for `actions.js` (`actions.d.ts` file)
- Tiny type improvements in `dataInterface.ts`
- In `stores.d.ts` 
- I removed `sessions` as it is a separate store (change made long time
ago, this is a cleanup that was omitted)
  - Improved types for `surveyState`
- Marked some more dead code in coffee code (with comments) 

History: This started during Christmas time when most developers had ooo
time and as preparation to fix a bug. Bug was fixed accidently by doing
other work, but nevertheless I've finished the TS migration work.

### 👀 Preview steps

This doesn't touch any particular functionality, but rather a wrapper
for Form Builder, so any Form Builder related functionalities might be
affected by this PR. It woul be best to test FB thoroughly. By look... (continued)

7234 of 11333 branches covered (63.83%)

27868 of 34250 relevant lines covered (81.37%)

1.6 hits per line